Paul Pfeister
Paul Pfeister
So this one checks out locally.... Unsure as to why it's failing on the runner. Will be working on improving the tests so it doesn't get automatically excluded. Will merge...
Added the label in case it gets lost in the meantime --- should give credit as of today
There are some changes seen in the diff but not mentioned in the PR -- are these intentionally pushed? Just to be clear.
There are a handful of separate deletions ---- [[see your diff here] ](https://github.com/sherlock-project/sherlock/pull/2544/files) The easiest fix is probably to save your changes elsewhere, `git reset --hard HEAD~1` to clean it...
Good catch. One of the downfalls of message checks. Are you in an allowed region or a blocked one? Could be useful in validating alternatives to eliminate it by the...
It hasn't even been 24hr since my last comment, people have jobs
No worries, things just take time Could you `checkout` the [feat/multiple-types](https://github.com/sherlock-project/sherlock/tree/feat/multiple-types) branch found in #2597 and try this command? `poetry run sherlock --site dailykos uirgheerig blue --local --print-all` Attempting an...
Merged #2597 into master (without dailykos). If you could `git reset --hard 1d2c4b134f8125c4fdacc3d7cc107ec442832f33` and then simply change the `errorType` to `"errorType": ["message", "status_code"]` instead of `"errorType": "message"`, that should be...
(some of the automatic tests here will probably fail, that is expected with this change ---- no worries)
Huh. They all worked. Even better. Anyways, LGTM! Merging into master now