Owen Avery comments

Results 146 comments of


                                            Owen Avery

Performance issue with recursive macro expansion

It seems like an issue with the typechecker

Rustc behaviour with loops in const/static context

It looks like most [loops](https://doc.rust-lang.org/reference/expressions/loop-expr.html) are allowed since [1.46.0](https://blog.rust-lang.org/2020/08/27/Rust-1.46.0/), seemingly with the single exception of `for` loops.

Foreverstack: `resolve_path` should return expected instead

I tried that a while back -- quickly turns into a mess

Foreverstack: `resolve_path` should return expected instead

I added a vector-by-reference parameter to store `Error`s -- you could always create a new class to store errors, that could be translated into instances of `Error`, and use that.

Foreverstack: `resolve_path` should return expected instead

`resolve_path` might error out for reasons other than failure to resolve a segment -- say, too many leading `super` segments. Also, are you *sure* `resolve_path` can't produce multiple errors? I...

Adjust external crate lowering and type checking

I thought about initializing `ImmutableNameResolutionContext` sooner, but I didn't think it would make sense to do so before the name resolution context is expected to become immutable.

Adjust external crate lowering and type checking

> I think i need an example of the issue you were seeing that you needed this try to add a little more info into your commit messages its super...

Fix Issue 3351: Shared discriminator having the same value<

> apologies, im back No problem

Refactored to use implicit insert and remove insert_type method from context object #3395

You don't have to keep recreating the PR, you can just force-push

Refactored to use implicit insert and remove insert_type method from context object #3395

Looks good, just missing the removal of a few `insert_type` calls