gccrs icon indicating copy to clipboard operation
gccrs copied to clipboard

Fix Issue 3351: Shared discriminator having the same value<

Open badumbatish opened this issue 10 months ago • 7 comments

Fixes #3351

Overriding on the compile item visitor, I am not sure if this is the right way to go?

badumbatish avatar Feb 26 '25 10:02 badumbatish

redundant header include, i have noticed, will fix after review

badumbatish avatar Feb 26 '25 10:02 badumbatish

LGTM nice work

thank you for your guidance!

badumbatish avatar Feb 27 '25 12:02 badumbatish

Looks like you just need to fix that clang format lint

philberty avatar Mar 14 '25 17:03 philberty

Looks like you just need to fix that clang format lint

sorry, will fix this after my spring break

badumbatish avatar Mar 23 '25 19:03 badumbatish

just need this formatting fixed and we can merge

philberty avatar Mar 28 '25 17:03 philberty

apologies, im back

badumbatish avatar Apr 12 '25 01:04 badumbatish

apologies, im back

No problem

powerboat9 avatar Apr 12 '25 03:04 powerboat9

close this due to staleness and lack of capacity, please feel free to reimplement these changes in your own PRs.

badumbatish avatar Jul 20 '25 02:07 badumbatish