Christian Shum-Harden
Christian Shum-Harden
Looking to help PR this, any advice on where to start? Here's my best guess so far: https://github.com/nfl/react-native-admob/blob/master/ios/RNDFPBannerView.m#L65-L77 Currently this only allows an enumerable adSize. ``` - (void)setValidAdSizes:(NSArray *)adSizes {...
It is up to the implementer to call `rewind()` which returns the current Helmet state. You should call `rewind()` directly after `renderToString()` to get the state of Helmet at the...
if you're server side rendering helmet then the scripts loaded in `` are guaranteed to be loaded before react renders (async or not). It sounds like you aren't server-side rendering...
I have a feeling #26 fixes this issue by verifying the GPT API is ready. Will take a look at it soon™
I believe it would need to be a different property since `viewableThreshold` is a measure of the area of the ad within the viewable area. We'd need to measure the...
Can you provide a failing test case in the test suite here to highlight your issue? I'm having a little trouble following it. If you're talking about `setTargeting` then you...
The ad placeholder from the Google Publisher Console are not deleted when the component is unmounted
My guess is GPC is not rendered inside Bling. You could query select and remove the GPC DOM wrapper or call some GPC destroy method... Id execute it only if...
The ad placeholder from the Google Publisher Console are not deleted when the component is unmounted
That should be pretty straight forward if you figure out the wrapping div or if the console comes with an API to destroy itself. PR it!
Thanks for the note @stevearoonie. The "Basic Example" is fixed in PR #56, but a few other things still need to happen before that PR is ready for merging. Hoping...
Started working on a PR for React 16 in #56, it also contains an upgrade to react-router 3.2. But I haven't tried to upgrade to react-router 4 yet. It might...