Christian Shum-Harden

Results 18 comments of Christian Shum-Harden

Have you tried passing it in as an `Array` of `Arrays`? Here's an example in the example folder: https://github.com/nfl/react-gpt/blob/32e0f19cc6102e6ece05bb7e7bc0097dcf672f85/examples/apps/routing/app.js#L42 ``` slotSize={[[728, 90], [970, 90]]} ``` Also, thanks for raising this....

None right now, but this seems like a feature that wouldn't be difficult to add: https://support.google.com/dfp_premium/answer/2811375?hl=en Maybe by adding the following props to `Bling`: ``` ``` Or with an optional...

@mmairs9 I'm down to merge this if you can just make the couple small changes noted in the review.

I have the same question, the following "Features" policy checks do not pass. Are there any plans to develop these features? Summarized, policy check 10 and 13 require you to...

@alanStocco if you'd like I can PR this solution into the main repo: 1. Update UI for feature names and purposes per vendor https://github.com/Openmail/system1-cmp/pull/16 2. Direct link to vendors https://github.com/Openmail/system1-cmp/pull/17...

Definitely sounds like a worthwhile refactor!

Can you provide some sample code or a test case in the tests that shows this happening? https://github.com/nfl/react-gpt/blob/60f6ce0ccd02e3c423b772b42de50ba776d883e7/docs/Guides.md#refresh-vs-re-render If no props are changing (you said same `adUnitPath` and `size`) then...

Something in [v1.4.12](https://github.com/swc-project/swc/compare/v1.4.11...v1.4.12) (and still present in v7.22.8) of @swc-project/swc is causing the following error when targeting es5 + sourcemap: true ``` Caused by: relative URL without a base at...