Damir Jelić

Results 351 comments of Damir Jelić

Oh one thing. We should add a changelog entry, though let's do so in a separate PR.

The test fails, but CI did not notice this because the make file eats the error code. Not sure why the test fails since it works locally.

I think that this is mostly due to our PBKDF usage in the default case when we encrypt the store. The usage of a random key is possible with our...

Yes, instead of requiring the usage of a passphrase that is used to derive the encryption key, we should let users provide an encryption key themselves. This avoids the slow...

Sorry, I missed the ping initially. > We think there may already be some kind of event when an identity changes, but we need to make sure you can listen...

> [@poljar](https://github.com/poljar) will make sure this is reported to Sentry so we can see how many people are affected. PR is here: https://github.com/matrix-org/matrix-rust-sdk/pull/5496

PR to report things only once per Client is here https://github.com/matrix-org/matrix-rust-sdk/pull/5588. I forgot about this despite @richvdh warnings that this will be a problem. 🤦

I'm afraid that this will have to wait for https://github.com/matrix-org/vodozemac/pull/206 and its deps.

Let's close this for now. We're going to collect merge conflicts for quite a bit here otherwise.

https://github.com/element-hq/element-x-ios-rageshakes/issues/1745 is not at all about any passphrase/key, the user doesn't have secret storage enabled at all. I'm not really convinced that it would need Rust work either, what makes...