Damir Jelić

> > Looks good, but now that #3517 has been merged we can add a test confirming that we put things in the right place. > > Can I have...

> Out of interest, do you know why [`Session::encrypt`](https://github.com/uhoreg/matrix-rust-sdk/blob/fc1dabf312a28457bfd2d189bc4c9bc04c4ebac8/crates/matrix-sdk-crypto/src/olm/session.rs#L153) uses `json!` instead of constructing and serializing a `DecryptedOlmV1Event`? Nowadays probably just for historic reasons, we didn't use to have the...

As https://github.com/matrix-org/matrix-rust-sdk/pull/3964 has been closed, this should be done, I'll leave this issue open until there's a EX-iOS release confirming this.

This isn't particularly actionable. It would be nice to get a bit more info: 1. Which requests 2. Which application Nevertheless, let's guesstimate what's going on. You can obviously set...

Superseded by #160.

Would that help that much? Large parts of the bindings assume SS support, do we even expose the sync v2 methods?

> Good point. I haven't actually looked further into the bindings yet because I'm blocked on logging in due to the PR mentioned above. I suppose the v2 methods could...

Now that we have the `SenderData` and it has a `compare` method, something like this might help: ```diff diff --git a/crates/matrix-sdk-crypto/src/olm/group_sessions/inbound.rs b/crates/matrix-sdk-crypto/src/olm/group_sessions/inbound.rs index f43e013e4..58c0579c7 100644 --- a/crates/matrix-sdk-crypto/src/olm/group_sessions/inbound.rs +++ b/crates/matrix-sdk-crypto/src/olm/group_sessions/inbound.rs @@...

The solution from OP was never implemented. But sure, some noise has accumulated in this issue. Opened https://github.com/matrix-org/matrix-rust-sdk/issues/4698 as a replacement.

Here's the list of events that are accepted in the clear: https://github.com/matrix-org/matrix-rust-sdk/blob/737e06b581fcf5087df033bf0e80e4d2cb2799e4/crates/matrix-sdk-crypto/src/machine/mod.rs#L1331-L1351 Or rather, anything that has an empty branch isn't handled if it's in the clear.