Patrick Ohly

Results 1006 comments of Patrick Ohly

> Before you push a new change, It would be great if you could either rebut or ACK+resolve comments that are addressed. I'll definitely ACK changes that I have made...

/test pull-kubernetes-integration pull-kubernetes-verify pull-kubernetes-verify-lint pull-kubernetes-unit pull-kubernetes-node-e2e-containerd-1-7-dra pull-kubernetes-kind-dra I am feeling lucky... :grin: However, I already some tests locally. There is one known, odd (random?) failure: $ go test ./pkg/api/testing ---...

/test pull-kubernetes-e2e-kind-canary Test of https://github.com/kubernetes/test-infra/pull/32898 (= https://github.com/kubernetes/test-infra/pull/32867#discussion_r1663258649).

/test pull-kubernetes-e2e-kind For comparison of the number of tests.

/test pull-kubernetes-integration pull-kubernetes-verify pull-kubernetes-verify-lint pull-kubernetes-unit pull-kubernetes-kind-dra The E2E node jobs (pull-kubernetes-node-e2e-containerd-1-7-dra) are hard-coded to enable v1alpha2, so they are not usable here. We either need two versions of them or...

I've force-pushed an [update](https://github.com/kubernetes/kubernetes/compare/5f6ae717e1d70e6e01ff8f36821e87dc28c37dad..27153f1d93d3b1ce07a79dee0d95300a324dfde3) which should fix running pull-kubernetes-kind-dra, solves some problems I found while testing locally, and addresses review feedback.

/test pull-kubernetes-integration

The e2e_node tests need a bit more love and care... I'm on it.

I addressed review feedback and linter hints. I gave up my stance that wrapping of errors (`%v` vs `%w`) should be considered on a case-by-cases basis and instead now always...

/test pull-kubernetes-node-e2e-crio-cgrpv1-dra Job updated, might work again.