Lennart Poettering

Results 1507 comments of Lennart Poettering

So, then maybe go back to my vpick suggestion, i.e. use the vpick provided basename here?

yeah, but where do you derive it from again? it's from the basename of the image, i.e. in vpick it's the basename vpick uses.

> Not necessarily, in fact if it gets to this bit of code it means it doesn't match the image 1:1. Also this is a bug fix and it needs...

I frankly don't get this. Please split out the comparison function and add a test case as I already asked. This is not obvious at all to me. I also...

what are the two strings where the call fails? i.e. which image basename? which path?

but what are the strings that are actually passed to match_image_name_to_path()?

ah, so it is compares two filenames, rather than one filename and one image basename? great, then add a helper then converts a filename into an image basename, via the...

```c int path_extract_image_name(const char *path, char **ret) { assert(path); assert(ret); /* Extract last component from path, without any "/" suffixes. */ r = path_extract_filename(path, &fn); if (IN_SET(r, -EINVAL, -EADDRNOTAVAIL)) /*...

Ah, gentoo being bitten by their franken-/usr-merge, eh?