Lennart Poettering
Lennart Poettering
Seems the "is-supported" commit tripped up the CI?
so, how do you expect this stuff to be consumed by gdm? if gdm needs explicit support, can't it maintain a local translation table? i.e. it sounds a bit icky...
so, at the very least, can we find a better moniker than "name" for this? to me "session name" sounds like the id used for an ongoing session. but that's...
codewise i am fine with the PR. i just want a better name for this. sessionPick? preferredSessionSelection? preferredDesktopProduct? preferredDesktopEnvironment?
> The display managers all call this just "session" by the looks of it. So `preferedSession` would align most w/ the display managers and existing vocabulary. AccountsService calls it just...
or what about preferredSessionLaunch? After all the desktop entry describes what precisely to launch. I kinda like this the best name. i.e. move focus from the classification of the object...
i mean, people do call "desktop entries" also "launchers", hence i think this is quite nice.
CI unhappy: ``` ../src/udev/net/link-config.c:942:33: error: unused variable 'd' [-Werror,-Wunused-variable] _cleanup_closedir_ DIR *d = NULL; ```
besides the "long" looks good to me. please fix that. i'll leave final review to @yuwata though.
oh, and the hexchar() thing should be fixed too, see my comment