Lennart Poettering
Lennart Poettering
It's not Ok to add stuff to existing generator dirs, and expect this to work in general. If the unit is already referenced by some unit, but missing so far,...
lgtm, just some minor nitpicks
two more minor tweaks
can you provide the debug logs when this happens? ``` # systemctl service-log-level systemd-homed debug # journalctl -u systemd-homed -f ``` And then reproduce the issue in another window. This...
i cherry picked the first two commits into main, since they appear pretty obviously correct. for the others i need another look.
So, I sympathize with both patches, but I agree with @DaanDeMeyer on the negation thing: we should support inverted matches generically in the journal match logic. It's certainly more involved...
So I see now that the --strip thing already has been split out, in #23473... so ignore my requests asking for such a split-out
So I think this should be more fine grained and extensible. The thing is that people who trigger by .path probably want to know more than just the path, i.e....
(there's a TODO list item somewhere, which asked for also reporting info about dbus clients that manually started a service. I think we should make it easy to add that...
So thinking more about this, I have more questions. First, what's your specific usecase, can you explain? I am a bit concerned that people will start using this in ways,...