Lennart Poettering
Lennart Poettering
> As explained above, I don't think other filters are comparable to this one, although I can understand the push towards consistency. The point I am trying to make is...
> Would LogFilterRegex=~pattern1 pattern2 mean pattern1 and pattern2 are not allowed, or pattern1 is not allowed but pattern2 is (i.e. does ~ negates the list of only the attached pattern)?...
(my comments dont matter much, I am aware the points I raised are already existent in the code before this commit — and mostly bikeshedding – but it would still...
config_parse_many_nulstr() will deal with the drop-on ordering logic for you. Just use that.
The timeout is already requested in #10739. What precisely do you mean by "libfido2 itself fails"? Do you have some specific error case in mind? If so, what#s the error...
> > The timeout is already requested in #10739. > > I am not sure you linked the right issue? #19739 is the right issue. one digit typo
> What about not running udev rules at all for suspended device mapper devices? not running udev rules would mean all props are dropped that normally set by udev rules....
looks pretty ok to me, codewise. not a netlabel person though. maybe someone who is deeply involved with netlabel upstream could briefly state that this conceptually makes sense. i guess...