Lennart Poettering
Lennart Poettering
btw, if the goal here is to mark packets based on the interfaces they are on, then going by IP address/mask means we'll be abiguous if the same IP address...
Ok, so let's maybe take a step back: @topimiettinen what's your usecase for all this? How do you intend to use this? Can you elaborate?
did another review round. codewise looks ok, but I'll leave the final review to @yuwata. The man page could use some love, i.e. for me as someone who is not...
integration tests would be good, that verify that the label rules are properly installed.
looks pretty OK to me. Can't judge how useful this IRL, but codewise all fine be me. I'll leave merging to @yuwata
This approach is a bit too adventurous for me, i.e. talking to PID 1 from a generator is a deadlock scenario, and running a generator out of generator context is...
> The idea is that we can peek into /sysroot/etc/fstab and figure out if there's anything interesting there. We could use a separate binary for this, but we'd need to...
multi-call binary that adds a symlink /usr/lib/systemd/systemd-sysroot-fstab → /usr/lib/systemd/generators/systemd-fstab-generator would make a ton of sense to me.
> Oh, you are saying this is actually doing what I am saying, I didn't grok that. But it is not, it's adding in stuff to existing generator dirs, and...
So here's one question: shouldn't we just remove the feature altogether? What's the usecase for supporting this? i.e. maybe an approach is to do what I suggested, but *also* log...