Martin Poelstra

Results 15 comments of Martin Poelstra

Hmmm, maybe I should have filed this in `typescript-tslint-plugin` repo instead. Just found that now, sorry.

It seems the `dev/next` branch (which you see by default on GitHub, but is not installed by default with npm) has an `install` command, instead of the cumbersome `query ...`....

That is true, and the trouble isn't really when the stream is aborted (because the promise is then rejected, thus 'breaking' the link). The trouble is when a stream is...

Hmmm, that's a very interesting idea indeed, and in terms of implementation is trivial. However, I'm not entirely happy with the name of that method then... Seems weird that `aborted()`...

We can certainly discuss that, but this issue is about something different: it is not about the `abort()` function, but the `aborted()` function. For context, a little history: `aborted()` returns...

> I guess that would come up in the process of implementing it. Or during writing the tests, more likely ;) On `halt()`, `cancel()`, etc, I would propose we open...

Thanks for this analysis. I agree this may come as a bit surprising behavior, especially given that apparently it's not documented well enough. > The first, to me, seems like...

I don't understand the question. As far as I can tell, the main 'fix' of this issue would be to improve the existing documentation. For handling the write errors, the...

Aaah, sorry, with "promise wrapping" I thought you wanted to wrap the resulting promise from a write call or something, because that's not what I meant. I don't want to...

> I do think it's worth the pain to give the developer as much information as possible in the console. Hehehe, "bring it on!" :muscle: > You say you don't...