Martin Poelstra comments

Results 15 comments of


Martin Poelstra

If abort() called before reader attached, all writes fail; if abort() called while promise argument of a write() call has not resolved, that write will fail when it resolves

I looked at both, they seem close (especially VError), but indeed do more than we need. I also had another look at the existing BaseError, and I think it actually...

If abort() called before reader attached, all writes fail; if abort() called while promise argument of a write() call has not resolved, that write will fail when it resolves

Yeah, I know about that performance difference. As I mentioned, I made [something similar](https://github.com/poelstra/ts-promise/blob/master/src/lib/Stack.ts) before. But it's exactly that property getter stuff for Error.stack that's making things tricky. For example,...

How to implement such case ?

Hi Marc, thanks for chiming in! I'm not entirely sure what you're trying to achieve exactly, your example seems a bit too contrived for me to grasp. Can you clarify?

From the perspective of the top-level API, abort() errors behave inconsistently

As commented in #47: > True. This is tricky, and I don't have a direct answer/solution here. It's always going to be a heuristic of course (like Node's eventEmitter.emit("error") stuff...

Trailing slash with globstar changed between v3 and v4

Updated the test code to: ```js const mm = require("micromatch"); const match = mm.matcher("/foo/**", { strictSlashes: true }); console.log(match("/foo")); // expect false console.log(match("/foo/")); // expect true ``` This still yields...