Pawel Nowosielski
Pawel Nowosielski
This is a set of ideas that have emerged in #827, omisego/plasma-contracts#189 discussions. I'm compiling some of the comments to this issue. ## Rationale Abstract Layer Design has already changed...
Experienced in Cabbage tests (fee_claiming) Client `get_balance` response is either `map` or `list(map)`. ``` Balance response for Alice: %{ "amount" => 3000000000000000000, "currency" => "0x0000000000000000000000000000000000000000" } 11:54:04.164 [info] Then "Alice"...
[transaction.create](https://developer.omisego.co/elixir-omg/docs-ui/?url=master/informational_api_specs.yaml#/Transaction/createTransaction) request body contains `owner` of account that funds will be withdrawn. @pthomalla suggested that better name would be `account` because `owner` is also present in `payments` and can provide...
https://github.com/omisego/elixir-omg/pull/1182#discussion_r357539248 - `owner` -> `outputGuard` - `currency` -> `token`
Standard response schema from the API (Watcher & ch-ch) consist of `version` field, set to `1.0`. We agreed the `version` means `OMG network` version. From the other side there is...
Work on client libs reveal problems which is related to not handling `messages` field of the `client_error` message. :exclamation: Please mind that client can be generated out from swagger spec...
[Number of children](https://github.com/yosriady/merkle_tree/blob/e73c4b146e4a76f0a5874ef8dc5d61c7de16a96b/lib/merkle_tree.ex#L26) suggest that we could build _k_-ary tries (`k > 2`). However proofs can only work for the binary tries (2 children) Do you think it makes sense...
Fixes #1750 All handlers and related helper methods was moved from `rpc/handlers` to the corresponding "category" file, e.g. block, transaction, trace... Handlers tests were refactor the same way. I introduced...
Fixes #1802
- Go through every handler tests and compare are they enough cover the 0.7 spec - Add more tests - Run actual node RPC request to check the actual responses