elixir-omg icon indicating copy to clipboard operation
elixir-omg copied to clipboard

/transaction.create - better name for funds owner

Open pnowosie opened this issue 5 years ago • 4 comments

transaction.create request body contains owner of account that funds will be withdrawn.

@pthomalla suggested that better name would be account because owner is also present in payments and can provide confusion

pnowosie avatar Jul 03 '19 10:07 pnowosie

Great idea, my question around naming would be: Are we currently using owner and account anywhere else in the API ? I would try to push us to using most consistent naming convention as much as possible.

Pongch avatar Jul 05 '19 04:07 Pongch

account for the sending address is an option - it is consistent with the account.* family of endpoints, since one is querying to create a transaction for a specific account.

An alternative would be a sender/receiver or sender_address/receiver_address which is very specific and quite standard, but not used elsewhere in the API

What we do have as other alternative for sender is spender (e.g. in Watcher's push notifications)

So a lot of options to choose from, depending on what one intends to be consistent with.

pdobacz avatar Jul 05 '19 07:07 pdobacz

why not put spender on an agenda :)

4siteweb avatar Dec 27 '19 20:12 4siteweb

@4siteweb this is already suggested by @pdobacz comment above 🙃

What we do have as other alternative for sender is spender (e.g. in Watcher's push notifications)

pnowosie avatar Dec 28 '19 13:12 pnowosie