Pawel Nowosielski

Results 38 comments of Pawel Nowosielski

This is cabbage test client - Watcher responds with array tirelessly. To reproduce see the usage of `Client.get_balance(...)` in `/priv/apps/itest/test/itest/fee_claiming_test.exs`

I'm not sure whether `messages` is an appropriate name though. :thinking: Watcher just passes anything it gets from ch-ch with it's [:client_error message](https://github.com/omisego/elixir-omg/blob/08b3c76b38b575cff67cbcfb76a5b8d1767f240d/apps/omg_watcher/lib/omg_watcher/http_rpc/adapter.ex#L57) This gets handled in the [fallback ctr](https://github.com/omisego/elixir-omg/blob/08b3c76b38b575cff67cbcfb76a5b8d1767f240d/apps/omg_watcher_rpc/lib/web/controllers/fallback.ex#L92)...

Also, as we followed Http-Rpc - these client errors are returned with `HTTP 200` status code. Wouldn't be it a problem to show 2 messages in swagger (1 succesful +...

Just a comment from my memory when I tested `status.get` both `HTTPie` & `SwaggerUI` were able to call it but swagger's `curl` example had failed. Difference is that for the...

I like @pdobacz's idea for simplicity. I can see a few drawbacks (or only misunderstanding on my side) 1. How we can provision another instance of ch-ch? We'd need to...

After discussion we discovered a few critical requirements that proposed solution has to meet. 1. System cannot lose transactions, once accepted tx has to be included in future block(s) 2....

> It is true that only one node has to cut a block and publish it, but that does not mean it needs to be the master node. This is...

However I think I can refine the above points to these: 1. System cannot lose transactions, once accepted tx has to be included in future block(s) (#774) 2. No node...

> what role does MQ have? It serves as mempool for non-master node in case master will crash. But when master is able to commit a new block to the...

> what happens with transactions not yet included in a block? Good point, it somehow slipped out of the picture. To ensure (1) we need to put received txs in...