Piotr Nowojski

Have we asked Apache's legal team about that?

> I wonder about the way the SourceOperator calls through the stack via pauseOrResumeSplits while also being called back with watermarks. My intuition would have been to do the pausing...

> I'd prefer this to be a single suqashed commit with the use of Co-Authored-By. IMHO there is no benefit in merging the individual commits because they are very much...

> @mxm Thanks a lot also from my side for you contributions. However, @pnowojski this PR was not orphaned! (I wrote to you that I'm on vacations.) Yes, sorry for...

There are still some related test failures: > Documented option pipeline.watermark-alignment.allow-unaligned-source-splits does not exist. and > Sep 09 15:10:03 [ERROR] Errors: > Sep 09 15:10:03 [ERROR] PulsarUnorderedSourceReaderTest.supportsPausingOrResumingSplits(PulsarSourceReaderBase, Boundedness, String)[1] »...

> On another note, do you think it makes sense to add a configuration option to disable using split alignment entirely? I'm a bit worried this feature might cause issues...

Yes, it took longer than it should have. Good that it's finally been merged 🎉

The initial set of ignored failure reasons was not well thought through and has been changed/adjusted over and over again, once we found a good example that a failure shouldn't...

I'm fine with that

Thanks for the review! > Why only add the download metric? While you are at this, you could have also simply added metrics for, e.g., merge/clip. That was the scope...