flink-shaded icon indicating copy to clipboard operation
flink-shaded copied to clipboard

Publish maven artifact containing shaded sources

Open zentol opened this issue 8 years ago • 3 comments

When working against the shaded dependencies it is not possible to jump to the source of a class, since we don't build source jars.

The source jars can be created by adding the following lines to the maven-shade-plugin configuration:

<createSourcesJar>true</createSourcesJar>
<shadeSourcesContent>true</shadeSourcesContent>

This is mostly blocked by legal questions:

  • Do we have to modify the release process for these jars?
    • Do we have to vote on the shaded source release?
    • Do we have to modify NOTICE/LICENSE files?
  • Are we allowed to publish a sources jar that isn't actually the source of the project?
  • Are we allowed to publish a sources jar that not necessarily can be compiled to the binary?
    • If the shaded source and binary are the result of 2 separate shading processes we can't guarantee it.

zentol avatar Aug 14 '17 13:08 zentol

Have we asked Apache's legal team about that?

pnowojski avatar May 15 '18 09:05 pnowojski

Have you now? If there is a Jira can you link to it?

kennknowles avatar Oct 23 '18 02:10 kennknowles

Can we add some links to link the corresponding dependencies to the source on Github ?

peizhouyu avatar Oct 17 '19 12:10 peizhouyu