Michael Mok

Results 123 comments of Michael Mok

> I think point (2) should be addressable similar to what was done in #146 (do not inject the overlay for excluded entries). I tried to use the existing `exclude`...

This change is not safe, it will likely break HMR when you change something other than React components (e.g. failing to force refresh). If you look at [this code](https://github.com/facebook/react/blob/bd4784c8f8c6b17cf45c712db8ed8ed19a622b26/packages/react-refresh/src/ReactFreshRuntime.js#L687-L736), the...

Is there any examples you can provide? All code in this repo is written as ES5-compliant as possible (and also in CommonJS), so I don't see it causing trouble in...

> I hope this is enough context - if not - I can create a sample repo. This is great - I will work on fixing the issues this week.

> I didn't hear your feedback on the subject of this issue - splitting the runtime (browser end) code and webpack (node end) code into separate packages. > The easiest...

I'm getting confused. If you trave the code paths that actually gets into Webpack's `entry` option, you can clearly see that no code other than the overlay/the socket integrations/the refresh...

> Steps to reproduce the core issue: > > ``` > git clone https://github.com/pmmmwh/react-refresh-webpack-plugin > cd react-refresh-webpack-plugin/examples/typescript-without-babel > yarn > yarn webpack --mode development --hot > grep '__webpack_require__.*querystring' dist/main.js >...

> What are the possible workarounds there? I can probably tweak webpack to use a node_module instead of external require if it comes from native-url. I think the best bet...

> I'm trying to do just that right now. It's the first time I dig deep into webpack and stuff really, so my attempts so far are failing 😦. Any...