Michael Mok

Results 123 comments of Michael Mok

> > In Metro, this is handled by re-evaluating the parent when this happens, but I am not sure if this can be done in Webpack. > > I think...

Hey all - Thanks for participating in the conversation 😺! I am happy to announce [`v0.1.0`](https://www.npmjs.com/package/@pmmmwh/react-refresh-webpack-plugin) is out now 🎉

Hi, can you provide a bit more insight what browsers you're running on? This most likely are related to how we consume webpack call stacks currently, but might be also...

OK, so let me address this properly. This issue is only addressing **RUNTIME** errors (i.e. when the browser executes code, not when Webpack compiles). For runtime errors, this behaviour as...

> Maybe this package should support this? npmjs.com/package/react-error-overlay Or maybe allow for someway to change the error overlay so it can be swapped out. You can always use the `overlay`...

Hi, I'm planning to add something to the overlay that you can import and mark an error as ignored when you catch the error. Does that cover your use case?...

How do you think your proposal can be implemented? I feel quite strongly that most uncaught runtime errors should be warned, can you explain the situation a bit more?

This doesn't really work though, because `errorChecker` would be a function in Node.js, and `handleRuntimeError` runs in the browser. The API would at least be like so: ```ts interface ErrorOverlayOptions...

I believe this does not impact the functionality - it is just a warning. It's definitely false positive here, because we try to detect if the HMR plugin is injected...

If they both run in the same Webpack instance there are no safe way to disable it because the runtime is injected globally and any HMR to any entry would...