Michael Mok comments

Results 123 comments of


                                            Michael Mok

Updates loader-utils to 3.2.1 due to Security Vulnerability

> I guess this fix may only work on Webpack 5, not sure what the standard way of handling that is in this project. > > I wouldn't be opposed...

Updates loader-utils to 3.2.1 due to Security Vulnerability

Will be fixed in `v0.6.0`.

Using the external configuration item of webpack in the development environment can cause react refresh to fail

Unfortunately externalizing React is tricky as transforms depends a lot on injection order - echoing the comment above it would be good to look at the sandbox I created.

[docs] possible inconsistency on SafeAreaProvider in Expo Router docs

I think the docs here is still inconsistent - do we need `SafeAreaProvider` in the root layout or not? The migration guide from React Navigation says no, but the Safe...

[docs] possible inconsistency on SafeAreaProvider in Expo Router docs

I would be open to help with a PR but I'm uncertain which behavior is the wanted one 😅

HMR Logs Indicate Success, but React Component Doesn't Update in Single-SPA

Hi, sorry for my silence. A new version of the library have just been published, can you try and see if that resolves the issue? Also, since you are using...

Middleware crashes when JWT is expired

> Any chance you can elaborate what you exacly mean when you say to obtain an expired JWT? And how do you use it? We have a fairly standard set...

Drop loader-utils dep

Hi - unfortunately we cannot do this right now as we support Webpack v4. This will be resolved in #851.

Empty module import after upgrading from 0.5.15 to >=0.5.16

Hmm. I think I have a hunch - seemingly `this` is not passing along correctly, and that is probably due to the change in how the module factory is defined....

Empty module import after upgrading from 0.5.15 to >=0.5.16

Thanks for reporting this! The fix for this have now been released with `0.6.1` (also backported to `0.5.17`).