Pietro Marchini
Pietro Marchini
@cjihrig, @RedYetiDev, I think that this PR is ready to be reviewed. I tried to refactor the code a little bit to improve readability and added some tests for color...
@mcollina, I just fixed a broken test. Could I please ask you to trigger the CI again? 😁
Hey @JacopoPatroclo, thanks for the PR. Could you please add tests to cover the new behaviour? Also, could you please update the documentation?
@jakecastelli thanks for pointing it out!!! there's no rush, I'd say we could just ask @JacopoPatroclo to manually rewrite the history!
Huge +1 from me
Hey @AriPerkkio , thank you very much for the follow-up and for the suggestion! I'll take a look asap 😁
These changes have broken the following test: https://github.com/nodejs/node/blob/96457b433fb1b9cdcc7d957914ae815aa40a5c78/test/parallel/test-runner-extraneous-async-activity.js#L52-L68 I'm taking a look!
> > (particularly watch mode + process isolation)? > > yes I have tested, its working fine! both for `process` and `none` Hey @cu8code, regarding this: could you please also...
Hey @cu8code, commit linter is failing, could you please fix it? ☺️
https://github.com/nodejs/node/pull/58073 ← here's a first "poc". I'm still working on this, and any kind of feedback is more than welcome! This is the first step... I'm also working on adding...