Pietro Marchini comments

Results 76 comments of


                                            Pietro Marchini

test_runner: ensure test watcher picks up new test files

@cjihrig, ok, I'm going to remove the new option solving only the initial issue. again: thanks 🚀

test_runner: ensure test watcher picks up new test files

@jakecastelli, rebased 🚀

test_runner: ensure test watcher picks up new test files

@jakecastelli, I had to rebase again cause of conflicts 🚀

test_runner: ensure test watcher picks up new test files

> Also, I hope you're still planning to add the cwd option 😄 @cjihrig, if this PR lands, I'll start working on it 😁 Should I open an issue before...

test_runner: exclude test files from coverage by default

I just pushed a new implementation for this feature based on default `coverageExcludeGlobs` value.

test_runner: exclude test files from coverage by default

Hey @Llorx, I proceeded as I saw no activity. I meant no offense 😞 Regarding the implementation footprint, the rationale behind the `fs` and `path` changes is that we decided...

test_runner: exclude test files from coverage by default

@Llorx don't worry, I totally understand your position, and I'm sorry you felt that way. I am sure that you will have a chance, and if you would like to...

lib: ensure FORCE_COLOR forces color output in non-TTY environments

Thanks @RedYetiDev, I was not sure about this, gonna change it!

lib: ensure FORCE_COLOR forces color output in non-TTY environments

> Fixes #55383 Fixes #52249 Regarding #52249, I would say we have two ways to ensure the fix: 1. Add a test in this PR to confirm that the issue...

lib: ensure FORCE_COLOR forces color output in non-TTY environments

While working on the tests I've seen this behaviour: ![image](https://github.com/user-attachments/assets/223c5869-4acb-4a0d-a955-0838f913e48f) This comes from this recently merged PR #54862. ```js import assert from 'node:assert/strict' import { test } from 'node:test' test('failing...