Chris Plummer
Chris Plummer
> @plummercj - Thanks for the review. Do you agree that these are trivial changes? ok
Changes are trivial.
Here is output from a test run that might be useful when reviewing the test: Got main thread: instance of java.lang.Thread(name='main', id=1) Waiting for events: EventSet for test case #0:...
I had to undo the last change that checked if the breakpoint was the expected one. There were two issues. The first was that the breakpoints are not in order,...
> ./core.22317 4371398656 bytes It would be a lot easier to read if this was converted to mb.
Windows builds are failing: d:\a\jdk\jdk\src\hotspot\share\oops/klass.hpp(251): error C2220: the following warning is treated as an error d:\a\jdk\jdk\src\hotspot\share\oops/klass.hpp(251): warning C4267: 'return': conversion from 'size_t' to 'int', possible loss of data
@theRealAph I applied your patch and ran SA tests. I did not see the failures you mentioned to me. Is there anything else special I need to do?