8294993: LingeredApp test update

[kevinjwalls]

There are a few changes we can make to better understand the LingeredApp test when it goes wrong:

startAppExactJvmOpts() should not try and call finishApp unless the process isAlive, that just creates a misleading exception.

waitAppReady() is really waitAppReadyOrCrashed(), and should not timeout immediately after the 1 second sleep, or we lose a second of our timeout value (not critical with a long timeout, but seems more honest).

Show how long we waited when startup/crashing times out.

Show how long a good startup takes, so we have a basic for comparison when it fails.

Show if there are hs_err/core/mdmp files in the working directory after startup/crash attempt.

Also, in open/test/lib/jdk/test/lib/util/CoreUtils.java:

"Move core file" often seems unnecessary, core/mdmp usually being created in the current directory. But getCoreFileLocation() performs Files.move() which takes enough time to not be a no-op.

---

Progress

• [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue

Issue

• JDK-8294993: LingeredApp test update

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10613/head:pull/10613
$ git checkout pull/10613

Update a local copy of the PR:
$ git checkout pull/10613
$ git pull https://git.openjdk.org/jdk pull/10613/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10613

View PR using the GUI difftool:
$ git pr show -t 10613

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10613.diff

[bridgekeeper[bot]]

:wave: Welcome back kevinw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@kevinjwalls The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge[bot]]

Webrevs

• 03: Full - Incremental (f323d12c)
• 02: Full - Incremental (3fef5b77)
• 01: Full - Incremental (7fb57684)
• 00: Full (dba9e4ae)

[kevinjwalls]

Example output showing dump file size:

LingeredApp startup took 3085ms Check for hs_err_pid/core/mdmp files: ./hs_err_pid22317.log 181656 bytes ./core.22317 4371398656 bytes Started LingeredApp with pid 22314 crashOutputString = [# ...etc...

[plummercj]

./core.22317 4371398656 bytes

It would be a lot easier to read if this was converted to mb.

[kevinjwalls]

./core.22317 4371398656 bytes

It would be a lot easier to read if this was converted to mb.

OK yes, I'd like both... 8-)

LingeredApp startup took 3119ms Check for hs_err_pid/core/mdmp files: ./hs_err_pid14641.log 0mb (181706 bytes) ./core.14641 4168mb (4371353600 bytes) Started LingeredApp with pid 14638 crashOutputString =

[openjdk[bot]]

@kevinjwalls This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294993: LingeredApp test update

Reviewed-by: cjplummer, amenkov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 231 new commits pushed to the master branch:

• 8c86e92535afa52c4d454a3b8cc59ee5f8bb6477: 8295847: slow debug build error after JDK-8294466
• e122321cb599d2e0041029b34b306ce88117aef7: 8295844: jdk/test/whitebox/CPUInfoTest.java failed with "not all features are known: expected true, was false"
• df81b3c66a3b17fc5d10098ce879416affbddd40: 8295738: Automate javax/swing/JFileChooser/FileSizeCheck.java
• 68cf248b440a09c4d9bd16c862473f6a97cde279: 8295298: Automate javax/swing/JFileChooser/FileViewNPETest.java
• fefbddf83595c15bbfd110a59e718ebf9f79b554: 8291443: Obsolete the PrintSharedDictionary flag
• 5b3de6e143e370272c36383adac3e31f359bc686: 8284840: Update CLDR to Version 42.0
• 2f3f3b618500b5f112fabca30d4c6780b2a8e723: 8295792: Clean up old async close code
• 5ac6f185eec9efb063bf271516df6529b732a043: 8290010: IGV: Fix UndoRedo Action
• c055dfc3ce5fe1cdc3e1a0d5a182df355a40c6b7: 8294565: IGV: ClassCastException when clicking on an edge in the graph
• 38983857883eb1b8948cb7645e77ecc97c4e4dd5: 8295461: IGV: Wrong src/dest nodes highlighted for edge
• ... and 221 more: https://git.openjdk.org/jdk/compare/7a194d31a3f2f78211f035f4591845bf2b465aec...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[kevinjwalls]

Thanks for the reviews!

[kevinjwalls]

/integrate

[openjdk[bot]]

Going to push as commit 9051dded84ef2d248483a6a1472def1eab79654f. Since your change was applied there have been 237 commits pushed to the master branch:

• f37a6055c469956a1e69715840a61f56b5cea425: 8295212: G1: Add wrapper for TruncatedSeqs that need separation by gc phase
• 6673cd857722d117b108590ba7f7c02f8622fc3b: 8295554: Move the "sizecalc.h" to the correct location
• 706d1b7508af58f7ed669bde4820ec9f80f58607: 8295798: (ch) Test java/nio/channels/Channels/ReadXBytes.java is very slow on Windows
• 89dafc002f934f7381a150e3f04fd1f830d183a4: 8292699: Improve printing of classes in native debugger
• 7520d0a72573ebaec0b6d9f9f1f1d87688bff8c0: 8295855: ProblemList jdk/jshell/CommandCompletionTest.java on linux-all
• 1d15e5cdd698045ab9c285c92b96126ed0666ac5: 8295716: Minimize disabled warnings in security libs
• 8c86e92535afa52c4d454a3b8cc59ee5f8bb6477: 8295847: slow debug build error after JDK-8294466
• e122321cb599d2e0041029b34b306ce88117aef7: 8295844: jdk/test/whitebox/CPUInfoTest.java failed with "not all features are known: expected true, was false"
• df81b3c66a3b17fc5d10098ce879416affbddd40: 8295738: Automate javax/swing/JFileChooser/FileSizeCheck.java
• 68cf248b440a09c4d9bd16c862473f6a97cde279: 8295298: Automate javax/swing/JFileChooser/FileViewNPETest.java
• ... and 227 more: https://git.openjdk.org/jdk/compare/7a194d31a3f2f78211f035f4591845bf2b465aec...master

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@kevinjwalls Pushed as commit 9051dded84ef2d248483a6a1472def1eab79654f.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.