jdk icon indicating copy to clipboard operation
jdk copied to clipboard

8292261: adjust timeouts in JLI GetObjectSizeIntrinsicsTest.java

Open dcubed-ojdk opened this issue 2 years ago • 5 comments

A trivial fix to adjust the timeouts for two of the sub-tests in JLI GetObjectSizeIntrinsicsTest.java.

This fix is being tested in my jdk-20+10 stress testing.


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8292261: adjust timeouts in JLI GetObjectSizeIntrinsicsTest.java

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9846/head:pull/9846
$ git checkout pull/9846

Update a local copy of the PR:
$ git checkout pull/9846
$ git pull https://git.openjdk.org/jdk pull/9846/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9846

View PR using the GUI difftool:
$ git pr show -t 9846

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9846.diff

dcubed-ojdk avatar Aug 11 '22 20:08 dcubed-ojdk

/label add hotspot-runtime /label add serviceability

dcubed-ojdk avatar Aug 11 '22 20:08 dcubed-ojdk

:wave: Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Aug 11 '22 20:08 bridgekeeper[bot]

@dcubed-ojdk The hotspot-runtime label was successfully added.

openjdk[bot] avatar Aug 11 '22 20:08 openjdk[bot]

@dcubed-ojdk The serviceability label was successfully added.

openjdk[bot] avatar Aug 11 '22 20:08 openjdk[bot]

Webrevs

mlbridge[bot] avatar Aug 11 '22 23:08 mlbridge[bot]

Changes are trivial.

plummercj avatar Aug 16 '22 17:08 plummercj

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292261: adjust timeouts in JLI GetObjectSizeIntrinsicsTest.java

Reviewed-by: cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 38 new commits pushed to the master branch:

  • c3d3662e52de434adb267485982fbf8541bdc0c8: 8292313: 2 runtime/cds/appcds tests fail after JDK-8284313
  • 3e122419b2979235f57c0dd549ca63647ea73753: 8290775: Some doc errors in DerOutputStream.java
  • ec53fba03933446024028555b87c6023895a5dc6: 8292361: Build failure on PPC64 BE after JDK-8290840
  • 4cc6cb9d9ddbcc540baac7b81398f2af83f93340: 8290041: ModuleDescriptor.hashCode is inconsistent
  • d1edda8ff52e172a85d102d7d5062b9cc401beea: 8292338: aarch64: Use cbnz instruction in gen_continuation_enter when possible
  • 21f4eb2233a95be44a5db59b7791cd952ddbd56e: 6521141: DebugGraphics NPE @ setFont();
  • 6e6ae596d6bd73909b90911e01fbd0c16f6335e1: 8292286: Convert PlaceholderTable to ResourceHashtable
  • ea2c82e74f5580f396920f9e561cbec80c03f373: 8291949: Unexpected extending of SupportedGroups
  • b5707b0376660cd8763e46d525ba614b08a59d7b: 8292196: Reduce runtime of java.util.regex microbenchmarks
  • b00eedeb029445417f99e8aa4e8fca12e5c69155: 8291511: Redefinition of EXIT_FAILURE in libw2k_lsa_auth
  • ... and 28 more: https://git.openjdk.org/jdk/compare/7ea9ba1f6c18ace5aa0896ab8676926fdc0d64ea...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Aug 16 '22 17:08 openjdk[bot]

@plummercj - Thanks for the review and for agreeing that the changes are trivial.

dcubed-ojdk avatar Aug 19 '22 19:08 dcubed-ojdk

/integrate

dcubed-ojdk avatar Aug 22 '22 19:08 dcubed-ojdk

Going to push as commit 8a0c3e53d541395ac32d656ac64d20ca0b9a187c. Since your change was applied there have been 116 commits pushed to the master branch:

  • 8e8ee4b6f22657a7efba8d7998f3c309f334a086: 8292596: Make SymbolHashMap a ResourceHashtable
  • aa9b8f04bf74d5fa00f2b27895e7369abea3a930: 8292043: Incorrect decoding near EOF for stateful decoders like UTF-16
  • f95ee7960328410551a6948053d1ff0ec3d8c53d: 8292566: Add reference to the java.nio.file package in java.nio package documentation
  • 45c3e898ed538545921395372fe507e9111401e1: 8292316: Tests should not rely on specific JAR file names (jpackage)
  • db772276848f6ad2d4d13e892bcd0eb3123d030f: 8282684: Obsolete UseContainerCpuShares and PreferContainerQuotaForCPUCount flags
  • 256b52387b7267c234f03aac19422e59a77d956f: 8292381: java/net/httpclient/SpecialHeadersTest.java fails with "ERROR: Shutting down connection: HTTP/2 client stopped"
  • e561933907bbab0a42f1796fa12f582b3a347312: 8292623: Reduce runtime of java.io microbenchmarks
  • dcd78020e4cd064061ac892c566c94fb744859c4: 8292708: Rename G1ParScanThreadState::flush to flush_stats
  • 16593cf51c3d994ba4a6d28ab97e519dfd53f37b: 8292717: Clean up checking of testing requirements in configure
  • c59f9b374b4497ab385675b0019c3647e6cddbbb: 8287828: Fix so that one can select jtreg test case by ID from make
  • ... and 106 more: https://git.openjdk.org/jdk/compare/7ea9ba1f6c18ace5aa0896ab8676926fdc0d64ea...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Aug 22 '22 19:08 openjdk[bot]

@dcubed-ojdk Pushed as commit 8a0c3e53d541395ac32d656ac64d20ca0b9a187c.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Aug 22 '22 19:08 openjdk[bot]

java/lang/instrument/GetObjectSizeIntrinsicsTest.java passed 18 times in a Mach5 Tier3 job set.

dcubed-ojdk avatar Aug 22 '22 19:08 dcubed-ojdk