plredmond
plredmond
Ok! I've tried (and reverted) both of the suggested performance improvements. Do we want to just merge this? I have no more commits to push.
Since you folks were ooo, I added questions that I had as NOTE/TODO/FIXME comments in the diff.
Thanks for your review. I've made requested changes and asked some questions to describe the follow-up work in comments. Let me know when/if it's ok to merge.
* Clippy: rename an unused variable which we'll use after completing the `get_member` case for unions * Added case to `infer_definition_type` for `AnnotatedAssignment` variant which returns `Type::Unknown` when the value...
Oh weird. ~~Maybe the CI-clippy is getting some stricter options than my local one.~~[Edit: No, I just forgot to run it] Ty
@zanieb thoughts on how to gracefully deprecate `lint.ignore_init_module_imports`? I can just grep for it and remove it, but that seems like it would break people who have the option in...
I think a design that leaves the door open to arbitrary user-provided solutions would be 1. HasChor defines a typeclass to serialise and deserialise via some chosen wire format type...
~~Hi, I've blocked out time to do this on Monday.~~ [Edit: I'll work on #9951, not this.]
Yes, it handles the type folio properly when keyd isn't running. --- To answer your question I did the following: (in type-folio, but "lying down"/disconnected) (in "flight mode") * via...
Ok, thanks for explaining that. I'll try looking at the code if I have time later to set up a build environment.