plredmond

Thanks for your review! I've looked over the comments above and can work on the changes later today. I need to devote this morning to a different task. > Ah...

> I don't think the rule flags `unnecessary_async` or `unnecessary_async2`. @MichaReiser These examples make the problem a bit harder. :slightly_smiling_face: I need to check if the visitor has a callback...

Hi! Sorry to let this PR languish. I have a paper deadline just before I start my astral internship, so I have to put this on ice until then.

Picking this up today. Sorry for the delay.

> IMO, `unused-async` is easier to understand than spurious (which I mainly associate with threading). It also fits well into other rules that catch "unused" syntax. Saving this rename for...

I've made a bunch of smaller/cosmetic changes per the comments above. Additionally, I've added four new test cases (two pass, and two fail). **Note, that the tests do not pass...

Sorry for the excessive number of commits here. I've had a bit of churn in the test cases because I found them confusing and reorganized them. The real work is...

Ok, I think everything is done except for this: > However, this _doesn't_ cover @charliermarsh's [suggestion](https://github.com/astral-sh/ruff/pull/9966#issuecomment-1939953539) to just omit checking methods in classes. I'm not sure how to approach that...

```sh-session $ cargo dev generate-all ... $ git diff diff --git a/ruff.schema.json b/ruff.schema.json index 871cce40b..90582fc67 100644 --- a/ruff.schema.json +++ b/ruff.schema.json @@ -3951,4 +3951,4 @@ ] } } -} +} \...

I also tried fetching and merging in the latest `main` in. Still no success. Strangely, I'm not seeing this locally. I'll look at the CI output.