plredmond comments

Results 71 comments of


                                            plredmond

F401 - Recommend adding unused import bindings to `all`

I swear I have fixed my pre-push hook now.

F401 - Recommend adding unused import bindings to `all`

Almost there, maybe? @zanieb @AlexWaygood Two unresolved threads left.

F401 - Recommend adding unused import bindings to `all`

I believe that i've resolved the outstanding requests. @AlexWaygood it might make sense to do a pass over the fixture tests now since there has been some churn, to see...

F401 - Recommend adding unused import bindings to `all`

This is ready for review again.

F401 - Recommend adding unused import bindings to `all`

Maybe it'll re-run after this last pull and resolve (if codespeed updates its comments).

F401 - Recommend adding unused import bindings to `all`

Ah, that's a good point. If we're comparing to `main` the performance could very well be different on an outdated branch.

F401 - Recommend adding unused import bindings to `all`

Rebasing.

F401 - Recommend adding unused import bindings to `all`

I've updated the PR description to reflect the diff after all review comments. Not sure what to do next. CodeSpeed might be a false-positive, but that should have been mitigated...

F401 - Recommend adding unused import bindings to `all`

Trying out Charlie's suggestion of using only one string in the violation struct. This caused /a lot/ of fixture changes to have cosmetic changes to help text and rule titles....

F401 - Recommend adding unused import bindings to `all`

Ok, that didn't work so I'm going to revert and then merge once tests pass.