Peter L Jones

Results 563 comments of Peter L Jones

Looks perfect! I'm never entirely comfortable with _forcing_ someone to take credit for something they don't feel they want to be credited for. Having the commit history can be enough....

I'd suggest you split this into separate issues... Looks a bit large and some parts may be more easily achieved than others. > We should look into making this configurable...

> (And if -j isn't yet used, it's allocated to whatever the long option will be :) .) I'll disagree with me on that one. First, I think we should...

> We don't need to redo the work of taskset. It's probably adequate for 80%+ of servers. Possibly not for 80% of server admins. But then _any_ solution would need...

... in fact... ``` Jamulus 1355 1 0 17:58 ? 00:00:00 /opt/Jamulus/bin/Jamulus-private -n -s .... ``` ``` $ taskset -pa 1355 pid 1355's current affinity mask: 3f pid 1401's current...

> De-Tagged since PR was closed and we're waiting on a refactoring of the settings. Which won't happen in 3.9.1, so moved to 3.10.0.

> What about the "Enable Small Network Buffers" option? The solution to the issue should document the means used to identify _all_ the affected checkboxes. Without that, it shouldn't be...

If my grep worked, the full list of checkboxes and whether they need changing looks like this: src/clientdlgbase.ui "chbLocalMute" OK "chbSettings" OK "chbChat" OK src/clientsettingsdlgbase.ui "chbAudioAlerts" Needs fix "chbAutoJitBuf" OK...

These changes are here, stacked up waiting on #2839: https://github.com/pljones/jamulus/tree/bugfix/%232723-self-label-checkboxes (These are initial screenshots. I'll post the final ones in the documentation change issue.) ### src/clientsettingsdlgbase.ui * "chbAudioAlerts" Needs fix...