jamulus icon indicating copy to clipboard operation
jamulus copied to clipboard

Initial "no JACK" message has no translation

Open SeeLook opened this issue 4 years ago • 7 comments

Describe the bug When Jamulus is started without JACK the message appears: image

and it is not translated

To Reproduce Just launch Jamulus but without JACK and with localisation other than English

Operating system Arch Linux

Jamulus Version 3.8.1beta1dev-4b5c6aaa-dirty

Additional context Seems to me like this message is invoked before QTranslator loads its stuff.

SeeLook avatar Sep 21 '21 19:09 SeeLook

I tested on windows and indeed it seems this message (and other messages related to sound initialisation) are generated before the selected language in Jamulus is loaded.

Another example is for instance, when the previous used/selected audio device is not available when Jamulus is started. In this case also the english text is displayed.

The issue header text is slightly miss leading in this case, as the translation does exists.

henkdegroot avatar Oct 01 '21 05:10 henkdegroot

Do you know what source files these strings are in?

Ok, found it.

ignotus666 avatar Oct 01 '21 05:10 ignotus666

De-tagging from release as it's not a quick fix.

gilgongo avatar Oct 01 '21 06:10 gilgongo

I know how to fix it but not sure when I'd be able to send it in. It's not complicated.

Edit: turns out it's not as simple as I thought and I don't know how to fix it. That'll teach me to be a clever clogs.

ignotus666 avatar Oct 01 '21 06:10 ignotus666

De-Tagged since PR was closed and we're waiting on a refactoring of the settings.

ann0see avatar Apr 23 '22 20:04 ann0see

De-Tagged since PR was closed and we're waiting on a refactoring of the settings.

Which won't happen in 3.9.1, so moved to 3.10.0.

pljones avatar Aug 29 '22 16:08 pljones

Dropping milestone and moving to backlog. It'll definitely not happen for 3.10.0 unless someone comes up with a straightforward fix that's compatible with the existing command line parser.

pljones avatar Apr 19 '23 16:04 pljones