Checkbox controls should be "self-labelling"

[gilgongo]

I think it's more accessible (and better UX) to use "self-labelling form elements".

So for example, it should be:

[ ] Audio Alerts

not split between a label and the control:

Audio Alerts [ ] Enable

The reason is mainly so that the control doesn't get separated from its label by a screen reader, but also in some contexts words like "enable", "on", "set" etc. might have unintended semantic or translation problems leading to "mode error". Better to let the user interpret the active state from the control than use a word for that state.

This issue currently applies to the Audio Alert and Feedback Protection controls in Settings. Other controls are compliant.

[ann0see]

Feedback Protection should also be changed

[ann0see]

@gilgongo can you do that and raise a PR?

[henkdegroot]

What about the "Enable Small Network Buffers" option?

[pljones]

What about the "Enable Small Network Buffers" option?

The solution to the issue should document the means used to identify all the affected checkboxes. Without that, it shouldn't be considered complete, as we need to have confidence we're finding and fixing all of them now.

We could also do with a coding style check for the issue to prevent it arising again.

[gilgongo]

Not sure how best to spec it, but checkboxes should have no other label other than the one that comes after the box. That label should also not contain words that clash with the function of the control like "enable..." "turn on..." etc. So they would need to change to:

[gilgongo]

@gilgongo can you do that and raise a PR?

Not sure I'm qualified to do that.

[hoffie]

Not sure why Input Boost was not a dropdown in the first place.

Huh, what version of Jamulus is this? Input boost is supposed to be a combo box (dropdown).

[gilgongo]

Not sure why Input Boost was not a dropdown in the first place.

Huh, what version of Jamulus is this? Input boost is supposed to be a combo box (dropdown).

Yes, got that wrong. The machine I'm on can't run Jamulus so I didn't check.

[ann0see]

Any news here?

[pljones]

On my list. I'll assign it.

[pljones]

If my grep worked, the full list of checkboxes and whether they need changing looks like this:

src/clientdlgbase.ui "chbLocalMute" OK "chbSettings" OK "chbChat" OK

src/clientsettingsdlgbase.ui "chbAudioAlerts" Needs fix "chbAutoJitBuf" OK "chbEnableOPUS64" Needs fix "chbDetectFeedback" Needs fix

src/connectdlgbase.ui "chbExpandAll" OK

src/serverdlgbase.ui "chbEnableRecorder" Needs fix "chbEnableDelayPanning" Needs fix

[pljones]

These changes are here, stacked up waiting on #2839: https://github.com/pljones/jamulus/tree/bugfix/%232723-self-label-checkboxes (These are initial screenshots. I'll post the final ones in the documentation change issue.)

src/clientsettingsdlgbase.ui

• "chbAudioAlerts" Needs fix - fixed Also adjusted layout to use "Form Layout" for the two group boxes. This layout makes it clearer which label is associated with which field in the editor. The "User Interface" section also lost the massive (and, in my view, ugly) gap:

• "chbEnableOPUS64" Needs fix - fixed Linux/Jack and Windows/ASIO: Again, I've used "Form Layout" for the "Input" and "Output" channel mapping sections and for the audio "Channel" and "Quality" controls.

• "chbDetectFeedback" Needs fix - fixed

src/serverdlgbase.ui

• "chbEnableRecorder" Needs fix - fixed Along with making "My Server Info" group box into "Form Layout":

• "chbEnableDelayPanning" Needs fix - fixed Along with a "Grid Layout" container, which (I think), makes things much tidier:

[pljones]

Also, I note that my builds, the misaligned faders issue isn't present: Linux: Windows:

So maybe it's something else in the toolchain?