Philippe Lewin

Hi @yuki, Thank you a lot for the PR. Do not worry about Codacy, it is not well configured. There is something I do not understand, after you used your...

> I choose this base32 library because I see that was very simple, and solved what I need. I didn't want to take a big project that has more functionalities...

Hi @N0th1ngmaN, Sorry only $login, $newpassword, $oldpassword are supported for now as posthook arguments. If you are interested in adding $mail as argument of the posthook you should fork /...

@ntoniazzi I think you are on the right direction, @coudot @ntoniazzi How do you feel about this draft design ?  'self-service' link will open a list of enabled features...

Hi @LiptonB > Yes, for security reasons we'd prefer not to have anonymous searches enabled. My thought was: if the user is already providing creds that can do the search,...

I am working on this on my dev branch mainly to avoid frustrating users. It can be really frustrating for users to enter a password thinking it is a good...

Here how it looks on my dev branch with all the currently supported rules : It is just for the demo, I won't recommend using other rules than the zxcvbn...

Nice code. Some remarks : 1) These 40 lines https://github.com/ltb-project/self-service-password/pull/114/commits/18ce3405463434587965e559f11a88367eb79e2e#diff-9ce97ef165e01124464cb1f193dc6c01R292 https://github.com/ltb-project/self-service-password/pull/114/commits/18ce3405463434587965e559f11a88367eb79e2e#diff-9ce97ef165e01124464cb1f193dc6c01R331 unless I missed something, should be simplifiable by `$old_password_hash = make_crypt_password_with_salt($old_password, $ldap_password);` 2) Avoid leaving commented out code. Is...

> Might require a change then... I wasn't sure how to use these functions so I copied/pasted from change_password (line 363 from my PR's functions.inc.php, 264 from master) - wouldn't...

I believe SSP should provide a way to override lang files without touching the provided files in /lang/* to offer more flexibility. For example, by including a new file "conf/lang_overrides.inc.php"...