Peter LaFosse

Results 175 comments of Peter LaFosse

In many cases is almost impossible to tell if the return value should be in rax or xmm0 however in this case as there are no uses of rax the...

I tried searching for this but couldn't find it. I was searching for "export" and "exporting" so I modified the name of the issue.

Seems like when adding support for this: https://github.com/Vector35/binaryninja-api/issues/1956 we might have implemented support incorrectly/incompletely Potentially more correct implementation: https://github.com/trailofbits/pe-parse/blob/ac6a07bdbf4034cd3977914fc6a1964ae65eff01/pe-parser-library/src/parse.cpp#L2289

could be done either as a `synthetic builtin` or just on the tokenization layer like the new ternary operator stuff. Probably we'd probably go with `builtin_max` rather than `MAX`

So I do believe we can support this as a separate architecture using some of the newer platform callbacks. I can look them up when I get to a computer,...

I believe the core issue here is that the stack remains unresolved. You need to figure out the underlying reason that the stack isn't being adjusted properly and fix it....

Ok this actually looks like its implemented as an intrinsic that sets RIP this is clearly wrong.

Broken lifting is here: Armv7: https://github.com/Vector35/binaryninja-api/blob/5320c6967cd380fd73be079675a960f22ba53b40/arch/armv7/il.cpp#L4962 Thumb2: https://github.com/Vector35/binaryninja-api/blob/5320c6967cd380fd73be079675a960f22ba53b40/arch/armv7/thumb2_disasm/il_thumb2.cpp#L2041

Changed the title of the issue as we do allow you to control this behavior in multiple different ways, by toggling the pure flag in the function attributes dialog and...