Peter LaFosse

Results 91 comments of Peter LaFosse

Yes that's the easiest solution. There are other more difficult solutions.

I 100% agree with this, and we're very sorry it's not going to make the 3.2 release. There were two ways we could have solved this issue: 1) https://github.com/microsoft/wdkmetadata/issues/1 this...

Nodes can be placed in suboptimal positions as well. When we implement the second pass graph layout optimization we should consider moving nodes as well.

There are lots of issue with edge routing currently, excessive cornering, routes on top of other routes, excessive crossings, bad ordering. During v1.2 we will be refactoring the algorithm to...

The following flowgraph will produce an error: ``` graph = FlowGraph() n1 = FlowGraphNode(graph) n1.lines = ['n1'] graph.append(n1) n2 = FlowGraphNode(graph) n2.lines = ['n2'] graph.append(n2) n4 = FlowGraphNode(graph) n4.lines =...

I'm glad the feature ultimately worked for you. Yeah it seems like there's probably a ton of room for improvement there.

This is slightly more involved than initial appearance as "Undefine Symbol" is already mapped to 'u' so instead 'Undefine Symbol' should be expanded to also be able to undefine functions...

Yeah the fear is that we'd be screwing up someones workflow. Perhaps thats fear is unfounded. I personally have never used "U" to undefine a symbol either.

I think what we need here is two things: 1) Notify the user that the disassembly is halted due to crossing a section boundary. 2) Add a setting that allows...

Yeah this is the line of code that does that: ``` result->m_callingConventionName = NoCallingConvention; //TODO: add calling convention stuff ``` This is slightly tricky because we don't really want to...