Peter LaFosse comments

Results 175 comments of


                                            Peter LaFosse

Offset types

So this is a feature I'd love. There is a way to implement this currently using a `DataRenderer` The problem in implementing this would be that you'd have to have...

When creating folders in symbols view with a filter collapsed folders open themselves

https://github.com/Vector35/binaryninja-api/assets/10556585/9d9ec553-b6e5-46e7-a862-f8e5925ba08c

Stack variable accessed with `lea` + `add` not resolved properly

The fundamental issue here is that we don't have in the MLIL Translator a path that simplifies `AddressOf(SomeVariable) + Offset` to `AddressOf(SomeOtherVariable)`

Strange HLIL related to stack variables. Stack layout issue?

This is too much information please try to simplify down exactly what you're asking for.

Strange HLIL related to stack variables. Stack layout issue?

I wonder why we're not picking up on the memset operation though. ... oh probably because of the `payload[1].w = 0x20` yeah looks like IDA handles this as such ```...

Strange HLIL with a messed up stack and use of undefined variables

either mark it as not a pointer or rebase your binary.

Strange HLIL with a messed up stack and use of undefined variables

This is a duplicate of this: https://github.com/Vector35/binaryninja-api/issues/5406 If we fix 5406 we'd not have this issue.

Regression: memcpy returning 8 values

One quick fix for this would be to go to the PLT entry and edit the function and remove the "Clobbered Registers"

Automatic sizing of stack variables

Duplicate of #2570

Add segments and sections from main header in MH_FILESET binaries

Sorry this PR has sat for so long. Do you happen to have a binary that demonstrates this issue?