binaryninja-api icon indicating copy to clipboard operation
binaryninja-api copied to clipboard

`U` should be mapped to "Undefine Current Function"

Open plafosse opened this issue 2 years ago • 5 comments

'U' Should be mapped to "Undefine Current Function"

plafosse avatar Aug 15 '22 16:08 plafosse

This is slightly more involved than initial appearance as "Undefine Symbol" is already mapped to 'u' so instead 'Undefine Symbol' should be expanded to also be able to undefine functions depending on context.

plafosse avatar Aug 16 '22 11:08 plafosse

Just going to throw my opinions into the wind. I have Alt+U mapped to undefine function and undefine variable, and u mapped to Display as Unsigned Decimal. I don't think I have ever used undefine symbol, because... well, I'm always undefining either a variable or a function. Does anyone else actually use that regularly enough for it to deserve a first-class keybinding?

nshp avatar Aug 16 '22 15:08 nshp

Yeah the fear is that we'd be screwing up someones workflow. Perhaps thats fear is unfounded. I personally have never used "U" to undefine a symbol either.

plafosse avatar Aug 16 '22 15:08 plafosse

While i originally remapped U to undefine function, there was That One Time when i hit it accidentally and it really screwed me up... so I remapped it to Ctrl-Shift-U.... and never looked back.

That being said, I am strongly in support of a context-sensitive one-action-to-Undefine-them-all, because I have to have a separate mapping for Undefine Variable, and I always forget what it is.

Also, I can't even figure out in what context Undefine Symbol gets enabled.

galenbwill avatar Aug 16 '22 16:08 galenbwill

I actually mapped "U" to be undefine symbol because it is what I was used to coming from IDA. Undefine function got remapped to CTRL + ALT + U. When I press a keyboard shortcut, I don't expect an action to take place on the entire function if I didn't select it's start address, just where my selection is. To me, undefining just the thing I have selected is what makes sense.

https://www.hex-rays.com/products/ida/support/freefiles/IDA_Pro_Shortcuts.pdf

FirehaK avatar Sep 12 '22 18:09 FirehaK