Philippe Laferrière

This was written in the past and we should audit it once again, as well as write more tests for it. Currently [lives here](https://github.com/cosmos/ibc-rs/blob/d8684e3a194cc53b944ccfc20c1793a650f5f89c/crates/ibc/src/core/ics23_commitment/mod.rs#L1) in the repo.

I'm also not a fan of needing that comment. Note also that I added a test to check that this conversion doesn't return a non-empty vector. The fix would look...

Investigate if store functions should return a `Result`

2

We currently return early if one of the writes to the store fails (e.g. [here](https://github.com/cosmos/ibc-rs/blob/8ed5c7e1492256805185a9fab1557c4af0f59ff8/crates/ibc/src/core/ics04_channel/context.rs#L331)). ibc-go assumes writes never fail (e.g. [here](https://github.com/cosmos/ibc-go/blob/d4b9f7359f6f407c135e5e71b59262407138281a/modules/core/04-channel/keeper/packet.go#L257)). We should think whether we want to also...

Should be `port_id_on_b` only, since `Counterparty::channel_id` is always `None` in `ChanOpenInit`.

Investigate using gitflow or alternatives

8

The main problem to fix is to be able to easily release hotfixes to previously released versions. This is currently hard and ad-hoc with everything being in `main`.

Investigate using "tagged identifiers" in connection/channel handshake

3

We recently introduced [this naming convention](https://github.com/cosmos/ibc-rs/blob/f8bc0335b298348e170089d97cb5790d635a66ad/crates/ibc/src/core/mod.rs#L4-L20) in the handshakes to facilitate understanding the logic. Correctness however still relies on the programmer. We could use "tagged identifiers" (see below) to let...

Remove `#![allow(clippy::result_large_err)]`

1

We need to make our main `Error` variant smaller, and remove [this line](https://github.com/cosmos/ibc-rs/blob/898b3932cb3981aef3d77737cb2fce7bae149290/crates/ibc/src/lib.rs#L14). Was added #341

We should define our own wrapper type for `time::Duration`, and implement the `borsh` `Serialize`/`Deserialize` on it. We can do it in another PR though. _Originally posted by @plafer in https://github.com/cosmos/ibc-rs/pull/273#discussion_r1050864396_

MoveNext not a function error

14

I got the following error, which VS code's console indicated I should report this here. The message is as follows: > workbench.desktop.main.js:77 [Extension Host] ====== Rewrap: Error ====== I @...

Our CI currently tests 2 things: 1. that we can open a channel 2. that we can send a token (2) should additionally ensure that `hermes` is able to relay...