Philippe Laferrière

Results 139 issues of Philippe Laferrière

The index of `ProcessState::get_stack_word(idx)` currently indexes into "word space"; that is, `index = 1` refers to the word the starts at stack-index 4. Words are not always stored on word...

Currently, the following `Cargo.toml` fails to build ```toml [workspace] [package] version = "0.1.0" name = "my-package" edition = "2021" [dependencies] reth-primitives = { git = "https://github.com/sp1-patches/reth", default-features = false, branch...

Follow-up to #255. Our `Error` enums have too many variants. We should drastically condense them following the ideas described [here](https://github.com/cosmos/ibc-rs/pull/255#issuecomment-1325805412). ```[tasklist] ### Tasks - [ ] Remove all host error...

S: errors
O: maintainability

[This path](https://github.com/cosmos/ibc-rs/blob/73556be62f90979a62328a15fabb90f96105d4a3/crates/ibc/src/core/context/timeout.rs#L71-L89) for example (and analogous paths for acks and `RecvPacket`), test that event is emitted properly, and no state change is applied.

O: testing

Our unit tests make extensive use of [default values](https://github.com/cosmos/ibc-rs/blob/0f3e03f84859d13cf842ec718eed3a2d8817a4d4/crates/ibc/src/core/ics04_channel/handler/timeout.rs#L398), including [in "util" functions](https://github.com/cosmos/ibc-rs/blob/0f3e03f84859d13cf842ec718eed3a2d8817a4d4/crates/ibc/src/core/ics04_channel/packet.rs#L313) implicitly used, which creates hard to understand relationships, and ultimately makes it difficult to understand why a...

O: testing
O: maintainability

After the core handler runs, we still don't know the `version` (which will be determined by the callback), so we shouldn't be returning an incomplete `ChannelEnd` (current workaround is to...

O: maintainability

Supersedes: #318 Blocked on: https://github.com/informalsystems/tendermint-rs/issues/1258 We should have the `ibc-testkit` not require `std` since there's no fundamental reason why it should. This involves: 1. Don't use `Timestamp::now()` which reads time...

A: good-first-issue
A: blocked
S: no-std
A: low-priority

Not all client's `ConsensusState` have the concept of a root (e.g. solomachine). Instead of [passing the root](https://github.com/cosmos/ibc-rs/blob/62575ceb2a233cc78bbf7324e826eeb95ccb91a1/crates/ibc/src/core/ics04_channel/handler/recv_packet.rs#L215) to `verify_membership` in the core handlers, we should instead fetch the root in...

A: breaking
O: maintainability
O: decoupling

We should implement this function ourselves in terms of `host_height()` and `host_consensus_state()` (see [basecoin-rs](https://github.com/informalsystems/basecoin-rs/blob/11565218e43388e8f4b6919400313eecfaa88458/src/modules/ibc/impls.rs#L420-L424)), since there are no other valid ways to do it. It should no longer be part...

O: usability

Ideally, we wouldn't need to depend on tendermint-rs, as tendermint is only one of many possible host consensus protocols. Non-tendermint hosts who don't plan on interacting with tendermint chains shouldn't...

S: deps
O: exploratory