Philippe Laferrière

According to ICS-24: >Identifiers MUST be non-empty (of positive integer length). `ConnectionEnd.counterpartyConnectionIdentifier` is defined to be of type `Identifier`. However, in `connOpenInit`, a `ConnectionEnd` is created with the `counterpartyConnectionIdentifier` set...

ICS-4: asynchronous acknowledgements during `recvPacket` are underspecified

1

Would it be possible to expand on what asynchronous acknowledgements are and how they work? The current explanation is quite brief. Also, the [ICS-26 `handlePacketRecv()` function](https://github.com/cosmos/ibc/blob/main/spec/core/ics-026-routing-module/README.md#packet-relay) doesn't account for them...

Use some nightly rustfmt features

2

We currently [manually look](https://github.com/0xPolygonMiden/miden-vm/pull/1155#discussion_r1402030806) at how import statements formatted instead of letting `cargo fmt` do it for us. It seems like these `rustfmt.toml` features were turned off because [the CI...

Simplifies the implementation of `OpBatchAccumulator` by decoupling the building of the batch with the conversion to the "bit format". This removes the need for [indexing variables](https://github.com/0xPolygonMiden/miden-vm/blob/ed0e87019fd1354b782cfab9bfbe5daa183a4e16/core/src/program/blocks/span_block.rs#L218-L223) which made the previous...

This can be useful to cleanup the advice map (mainly for debugability). Context: https://github.com/0xPolygonMiden/miden-vm/pull/1215#discussion_r1470168863

multiset checks: running product column should explicitly shift multiplicand

2

In our multiset checks docs, we currently describe our strategy for implementing multiset checks as a [running product column](https://0xpolygonmiden.github.io/miden-vm/design/lookups/multiset.html#running-product-columns), where values of `a` are multiplied in, values of `b` divided...

Implement`adv.push_smtset` and `adv.push_smtget`

2

Prior to #1215, these instructions worked with the `TieredSmt`. They are currently not used in the `smt` implementation, but could be useful to improve performance. _Originally posted by @bobbinth in...

#1215 replaced the `TieredSmt` implementation with the new `Smt`. It only added support for empty and single leaves though. We still need to implement the case where multiple key-value pairs...

`AuxColumnBuilder`: consider using a `BTreeMap` for requests

3

_Originally posted by @plafer in https://github.com/0xPolygonMiden/miden-vm/pull/1195#discussion_r1456524687_ It took me a bit to understand what this was doing, and I think we can improve it (readability- and memory-wise). The algorithm would...

test utils: `build_test*` macros should be replaced with a `TestBuilder` struct

1

The [`build_test!`](https://github.com/0xPolygonMiden/miden-vm/blob/a032ab4ac52dcca8671ae7ebea9f851943b0fe82/test-utils/src/test_builders.rs#L43) macro (and others) should be replaced by a `TestBuilder` struct. It seems like their purpose is to solve the telescoping constructor problem, which is cleanly solved by the...