Piotr Kuczynski comments

Results 253 comments of


                                            Piotr Kuczynski

Tests example illustrating no-extraneous-dependencies not failing when importing from subfolder

@ljharb is that helpful?

Tests example illustrating no-extraneous-dependencies not failing when importing from subfolder

Cool, thanks! I noticed that tests are not failing due to the issue I reported. You can also have a look at my demo repo directly to observe the issue......

Tests example illustrating no-extraneous-dependencies not failing when importing from subfolder

Perfect! Let me know if I can help any further...

Tests example illustrating no-extraneous-dependencies not failing when importing from subfolder

Did you checked the example repo I provided? https://github.com/pkuczynski/eslint-plugin-import-1919-demo

3.3 previews have moved to subfolder

This is actually true since quite a while, but nobody else reported an issue. Can you check again @ylluminate ?

Error running '__rvm_make -j16',

This should not be required anymore if you run `rvm get master`

Fix merging with empty values

@TehShrike I need this too! So I basically want to merge only when the new object has a value (avoiding nulls overriding). Something like here: https://www.rubydoc.info/gems/deep_merge/1.2.1 ``` :merge_nil_values DEFAULT: false...

False-positive for "error" causing issues in prefer-await-to-callbacks rule

I have similar scenario with a false positive: ```js export const formatErrors = errors => errors.map((error) => { ... } ``` There is no promise involved in this piece of...

False-positive for "error" causing issues in prefer-await-to-callbacks rule

I agree with @jturel, that checking for a param name is a poor linting. However, I am flooded with work so I would not be able to come up with...

Logs to the console twice

I would happily accept a PR if you have some time to work on it?