Piotr Kuczynski comments

Results 170 comments of


Piotr Kuczynski

Unble to install any ruby version through rvm on Monterey M1 Mac

@Meekohi would you like to come up with PR maybe?

Unble to install any ruby version through rvm on Monterey M1 Mac

Everything is here https://github.com/rvm/rvm/blob/master/scripts/functions/requirements/osx_brew. You can add `libffi` to `requirements_osx_brew_libs_default`. I am not sure if defining these extra flags would be necessary. You can start without them and see...

Allow building ruby 2.7.z on Fedora 36

> Looks like there are problems on fedora 36 with other rubies than the 2.7 line. Should we build all of them against openssl1.1? Yes, I think so. If older...

Skip merging if the destination is nil

I would vote for introducing this feature with an option to turn it off. My gem rely on deep merge and I have some bug reports on this kind of...

Skip merging if the destination is nil

Sure, we could do it in this way. Shall I prepare upgraded PR which introduce new option to turn this behaviour on?

[Postgres] `simple-enum` column should generate the same name if the two table shares the same type

Using `enumName` does not work for me. See https://github.com/typeorm/typeorm/issues/9233#issuecomment-1216733169

Optional namespace for `add_source!`

Adding sources at runtime should be rather done this way: https://github.com/rubyconfig/config#adding-sources-at-runtime However `config` has been designed to offer automatic env aware load, rather than manually stitching few files. I am...

Optional namespace for `add_source!`

Reload would not work with the proposed namespace either I guess?

Optional namespace for `add_source!`

If others agree, I am fine with accepting a PR with this feature...

Optional namespace for `add_source!`

@wwboynton would you still like to fire up PR for this?