Peter Kieltyka

Results 138 comments of Peter Kieltyka

alternatively, RealIP can change so it doesn't override r.RemoteAddr at all, and instead it will set a "RealIP" on the request context, I think that would be cleaner

Nice! I’ll update when I can.. it’ll be nice to finish the docs PR too and include a section on file serving too, embedding, etc. PRs are welcome :)

thank you @avdb13 -- I appreciate that, and agree tons of hypey projects, but also lots of truth to the primitives of web3

Great find and idea. I won’t have time for this one for a while but feel free to PR if you’re interested > On Sep 23, 2021, at 1:05 AM,...

thanks for the PR. I'll need to find some head space to think about this

I think the best solution is to stop overwriting r.RemoteAddr from RealIP middleware and instead setting a value on the request context

thanks for pointing out the inconsistency. I agree it should be at least consistent. The choice should be the one which is more efficient and requires less processing on chi's...

The fix on your end to pick your solution is an easy one. I haven’t had the head space to really feel put this problem and decide on the best...

at a quick glance, this looks good. maybe the wildcard check doesn't work? try to change `"*.example.com"` with `"sub.example.com"` and see if that solves it?

please paste sample / minimal main.go program with the issue (with the crash)