Peter A. Jonsson
Peter A. Jonsson
I just tried `ts-fix` and that also misplaced some return type annotations in a similar fashion. I'm guessing the cause is some underlying bug with the line/column start/end information for...
/remove-lifecycle rotten
The build failure in the test is because controller-runtime is < v0.15.0 and some version of something in a dependency isn't updated yet. Controller-tools 0.15 should not have this problem,...
/remove-lifecycle rotten
@rjbez17 I don't really know Go, but let me get back to you on that next week. And Go 1.21 doesn't help us for this particular issue, but I'm guessing...
@rjbez17 Considering I have no idea what I'm doing, I started with Go 1.21 in #406. I will take a look at 1.22 tomorrow, but that seems more difficult, so...
@rjbez17 Sorry, still learning about the go ecosystem. Have run `go mod vendor` like the error said the last time now (and rebased on top of latest master).
@rjbez17 it's been 2 months since I updated the PR to include `go mod vendor` results, could you please take another look?
> https://github.com/TerriaJS/terriajs/blob/dd2a2a5ac661724d39d1605c138df58ad9d8b556/lib/ReactViews/Tools/ItemSearchTool/SearchResults.tsx#L31 > > createRef is not valid in functional components and useRef should be used instead. @zoran995 Thank you for the help. If you really mean that createRef is...
Rebased to latest main to resolve conflicts, and updated CHANGES.md.