hierarchical-namespaces
hierarchical-namespaces copied to clipboard
kubernetes-sigs
Update to controller-tools 0.14.0
This updates golang.org/x/tools to a later version which fixes the crash in https://github.com/kubernetes-sigs/controller-tools/issues/880, which I believe is what is happening on the current main branch in this repository.
I'm really after the security fixes, so pick #373 if that smaller change is preferable to this.
Hi @pjonsson. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle rotten - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The build failure in the test is because controller-runtime is < v0.15.0 and some version of something in a dependency isn't updated yet. Controller-tools 0.15 should not have this problem, but my reading of the Compatibility section at https://pkg.go.dev/sigs.k8s.io/controller-tools#section-readme is that it requires Go 1.22.
@rjbez17 I know this project uses Go 1.20, do you have any advice?
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle rotten - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
If you wanted to take a stab at updating to go 1.22 I'd happily support that.
@rjbez17 I don't really know Go, but let me get back to you on that next week. And Go 1.21 doesn't help us for this particular issue, but I'm guessing starting with that will be easier since it is a smaller change.
Can I get the CI to trigger without your explicit approval, or do I need to join the kubernetes-sigs to make that happen?
The ok-to-test label should trigger the tests now. You can use /test all in a comment as well
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: pjonsson Once this PR has been reviewed and has the lgtm label, please ask for approval from rjbez17. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@rjbez17 Considering I have no idea what I'm doing, I started with Go 1.21 in #406.
I will take a look at 1.22 tomorrow, but that seems more difficult, so if you believe the 1.21 PR works I suggest start with merging that.
Even if Go 1.21 and the latest main branch "just" fixes a few of the security issues that Trivy is complaining about, we're closing up on 2 years since the last release so it would be nice with a release sometime soonish too.
@rjbez17 Considering I have no idea what I'm doing, I started with Go 1.21 in #406.
I will take a look at 1.22 tomorrow, but that seems more difficult, so if you believe the 1.21 PR works I suggest start with merging that.
Even if Go 1.21 and the latest main branch "just" fixes a few of the security issues that Trivy is complaining about, we're closing up on 2 years since the last release so it would be nice with a release sometime soonish too.
I agree and really appreciate your help here. Once we get this merged I'll try to find some time to time box a 1.22 upgrade and if not release a maintenance release within the next week or so.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@pjonsson: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-hnc-test | e7f864a086aa6c4b8f3b422c9f65e4b00a7315b7 | link | true | /test pull-hnc-test |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.