Peter A. Jonsson

Is this issue fixed by commit 09eb905332c3abe?

I haven't read any guidelines but the formatting style in Makefiles for many platforms is pretty consistent with using two spaces for each nesting level of ifeq/ifdef.

The first two commits are small and look like general improvements for other targets as well, could they be put in a separate pull request and merged as is?

Sorry for the confusing remarks, apparently Github does not show which commit I'm commenting on. The remark about squashing a commit was on the "Apply code-style to missing files" commit.

Some fixes that enabled more warnings from the compiler were merged to develop last week. Could you please rebase this on top of latest develop?

We have out-of-tree nrf5340 changes that I think will cause merge conflicts with this. My impression is that this PR brings the two nrf ports closer to each other. Is...

@Yagoor I think the build system is better at giving warnings now than it was when you pushed this change, could you rebase against the latest develop branch?

Is testing on hardware the only thing that remains, or what is the status for this PR?

I'm using Clang-14 on Ubuntu 22.04. Writing `while(cond);` is a compact way to represent a loop, but the semi-colon is easy to miss, and apparently leaving out the braces isn't...

You're right, most places don't give a warning, so I've removed a couple of while statements from the patch. I'm not sure what you are trying to say though, I...