Paulo Janotti
Paulo Janotti
The service needs to provide good observability to its users but it needs to be careful about not overwhelming the system with logging/metrics/traces. In this regard logging is typically the...
This is failing consistently on my local Windows run of `dotnet nuke Workflow`: ```terminal 10:27:36 [INF] > "C:\Program Files\dotnet\dotnet.exe" test C:\src\otel\dotnet\auto\test\IntegrationTests\IntegrationTests.csproj --configuration Release --framework netcoreapp3.1 --filter Containers!=Windows --logger trx --no-build...
Versions for source instrumentations are just marked with an asterisk. Perhaps it is worth to link to respective information on the package or copy it on our docs. See https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/pull/635#discussion_r861159969...
There are enough behavior behind the environment helpers, especially `SetExporter`, to justify dedicated unit tests. The tests should cover: - EnvironmentConfigurationMetricHelper - EnvironmentConfigurationTracerHelper
Review and make the property names for metric settings consistent, eg.: - `MetricExporter` is consistent with the spec name for the metrics exporter interface, but, some other properties use metrics...
Add integration tests that use the selected docker images: it is possible that our build requires dependencies that are not present on the some docker images, see https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/issues/703#issuecomment-1143088402 for an...
Currently some settings that apply to metrics and traces are under "Tracer" we should factor out settings that apply to all signals for consistency and to avoid confusion.
Changes that don't affect code should not trigger validation related to code (build and tests), eg.: changes to markdown files should only trigger markdown lint.
This is more to facilitate development and experimentation and perhaps an extension point for vendors. See https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/pull/314#discussion_r798054857 for the context. The profiler code currently assumes that the StartupHook has a...
**Describe the bug** Metrics for ocgrpc on bidirectional stream seem to be collected only for initialization and cancellation. **To Reproduce** Steps to reproduce the behavior: 1. Clone the census-instrumentation/opencensus-service repo...