Antoine Pitrou comments

Results 822 comments of


                                            Antoine Pitrou

Excessive memory retention using either mimalloc v2 or v3 on macOS

Random observation, but I don't understand this code, these two lines look weird: https://github.com/microsoft/mimalloc/commit/a1cfe9667c307a355c13b6f8381463e04ad6b04d#diff-aa9a92fb58ac9e5cb386ab5760eaf8d2e7f81da12aae09c43a9e1d102332ed77R168-R169 I would intuitively expect: ```c size_t csize = memid.mem.os.size; if (csize==0) { csize = _mi_os_good_alloc_size(size); }...

Excessive memory retention using either mimalloc v2 or v3 on macOS

I'm now trying this patch on top of 2.1.9 on our CI and it seems to fix the issue: ```diff diff --git a/src/os.c b/src/os.c index 61c9eebf..3441bc3d 100644 --- a/src/os.c +++...

Excessive memory retention using either mimalloc v2 or v3 on macOS

@daanx Do you think the patch in https://github.com/microsoft/mimalloc/issues/1025#issuecomment-2768863283 is ok? Or am I just misunderstanding things there?

Excessive memory retention using either mimalloc v2 or v3 on macOS

Thanks a lot @daanx !

Excessive memory retention using either mimalloc v2 or v3 on macOS

In https://github.com/apache/arrow/pull/45979 we were finally able to bump the mimalloc version used for Apache Arrow. Thank you!